Skip to content

Review Metrics: Display improvements #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illicitonion merged 1 commit into from
Jan 28, 2026
Merged

Review Metrics: Display improvements #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/prs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,8 @@ pub struct AggregatePrMetrics {
pub p50_needs_review_to_complete: Option<TimeDelta>,
pub p90_needs_review_to_complete: Option<TimeDelta>,
pub p100_needs_review_to_complete: Option<TimeDelta>,

pub iteration_counts: BTreeMap<usize, usize>,
}

impl AggregatePrMetrics {
Expand All @@ -276,6 +278,13 @@ impl AggregatePrMetrics {
m.needs_review_to_complete()
});

let mut iteration_counts = BTreeMap::new();
for metric in metrics {
if metric.first_complete.is_some() {
*iteration_counts.entry(metric.iterations).or_default() += 1;
}
}

AggregatePrMetrics {
p50_needs_review_to_first_review,
p90_needs_review_to_first_review,
Expand All @@ -286,6 +295,7 @@ impl AggregatePrMetrics {
p50_needs_review_to_complete,
p90_needs_review_to_complete,
p100_needs_review_to_complete,
iteration_counts,
}
}

Expand Down
101 changes: 64 additions & 37 deletions templates/review-metrics.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
}
.stats-container {
display: grid;
grid-template-columns: repeat(3, 1fr);
grid-template-columns: repeat(4, 1fr);
gap: 40px;
}
.reviews-container {
Expand All @@ -22,6 +22,12 @@
border: 1px black solid;
padding: 5px;
}
.module {
background-color: lightgrey;
border: 1px black solid;
margin-bottom: 10px;
padding: 5px;
}
</style>
</head>
<body>
Expand Down Expand Up @@ -51,46 +57,67 @@ <h3>Needs review to complete</h3>
<li>p100: {{format_duration(aggregate_metrics.p100_needs_review_to_complete)}}</li>
</ul>
</div>
<div class="stats-card">
<h3>Iterations</h3>
<ul>
{% for (iteration, count) in aggregate_metrics.iteration_counts %}
<li>{{iteration}}: {{count}} PRs</li>
{% endfor %}
</ul>
</div>
</div>

{% for module in modules %}
<h2>{{module.name}}</h2>
<div class="stats-container">
<div class="stats-card">
<h3>Needs review to first review</h3>
<ul>
<li>p50: {{format_duration(module.aggregate_metrics.p50_needs_review_to_first_review)}}</li>
<li>p90: {{format_duration(module.aggregate_metrics.p90_needs_review_to_first_review)}}</li>
<li>p100: {{format_duration(module.aggregate_metrics.p100_needs_review_to_first_review)}}</li>
</ul>
</div>
<div class="stats-card">
<h3>Created to complete</h3>
<ul>
<li>p50: {{format_duration(module.aggregate_metrics.p50_created_to_complete)}}</li>
<li>p90: {{format_duration(module.aggregate_metrics.p90_created_to_complete)}}</li>
<li>p100: {{format_duration(module.aggregate_metrics.p100_created_to_complete)}}</li>
</ul>
</div>
<div class="stats-card">
<h3>Needs review to complete</h3>
<ul>
<li>p50: {{format_duration(module.aggregate_metrics.p50_needs_review_to_complete)}}</li>
<li>p90: {{format_duration(module.aggregate_metrics.p90_needs_review_to_complete)}}</li>
<li>p100: {{format_duration(module.aggregate_metrics.p100_needs_review_to_complete)}}</li>
</ul>
</div>
</div>
<div class="reviews-container">
{% for pr in module.metrics %}
<div class="review-card">
<div><a href="{{pr.pr.url}}">{{pr.pr.repo_name}} #{{pr.pr.number}}</a></div>
<div>Created to Complete: {{format_duration(&pr.created_to_complete())}}</div>
<div>Needs Review to Complete: {{format_duration(&pr.needs_review_to_complete())}}</div>
<div>{{pr.iterations}} iterations</div>
<div>Time since created: {{format_duration(&Some(pr.time_since_created()))}}</div>
<div class="module">
<h2>{{module.name}}</h2>
<details>
<summary>Expand for details</summary>
<div class="stats-container">
<div class="stats-card">
<h3>Needs review to first review</h3>
<ul>
<li>p50: {{format_duration(module.aggregate_metrics.p50_needs_review_to_first_review)}}</li>
<li>p90: {{format_duration(module.aggregate_metrics.p90_needs_review_to_first_review)}}</li>
<li>p100: {{format_duration(module.aggregate_metrics.p100_needs_review_to_first_review)}}</li>
</ul>
</div>
<div class="stats-card">
<h3>Created to complete</h3>
<ul>
<li>p50: {{format_duration(module.aggregate_metrics.p50_created_to_complete)}}</li>
<li>p90: {{format_duration(module.aggregate_metrics.p90_created_to_complete)}}</li>
<li>p100: {{format_duration(module.aggregate_metrics.p100_created_to_complete)}}</li>
</ul>
</div>
<div class="stats-card">
<h3>Needs review to complete</h3>
<ul>
<li>p50: {{format_duration(module.aggregate_metrics.p50_needs_review_to_complete)}}</li>
<li>p90: {{format_duration(module.aggregate_metrics.p90_needs_review_to_complete)}}</li>
<li>p100: {{format_duration(module.aggregate_metrics.p100_needs_review_to_complete)}}</li>
</ul>
</div>
<div class="stats-card">
<h3>Iterations</h3>
<ul>
{% for (iteration, count) in module.aggregate_metrics.iteration_counts %}
<li>{{iteration}}: {{count}} PRs</li>
{% endfor %}
</ul>
</div>
</div>
<div class="reviews-container">
{% for pr in module.metrics %}
<div class="review-card">
<div><a href="{{pr.pr.url}}">{{pr.pr.repo_name}} #{{pr.pr.number}}</a></div>
<div>Created to Complete: {{format_duration(&pr.created_to_complete())}}</div>
<div>Needs Review to Complete: {{format_duration(&pr.needs_review_to_complete())}}</div>
<div>{{pr.iterations}} iterations</div>
<div>Time since created: {{format_duration(&Some(pr.time_since_created()))}}</div>
</div>
{% endfor %}
</div>
{% endfor %}
</details>
</div>
{% endfor %}
</body>
Expand Down