Manchester | 25-ITP-Sep | Hani Sadah| Sprint 2 | Coursework/sprint 2 by HANISADAH · Pull Request #836 · CodeYourFuture/Module-Structuring-and-Testing-Data

HANISADAH · 2025-11-01T22:26:36Z

Manchester | 25-ITP-Sep | Hani Sadah| Sprint 2 | Coursework/sprint 2

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

in this PR: Sprint 1 Coursework completed. errors fixed and questions answered

Briefly explain your PR.
I have answered all the tasks.

Hani Sadah

github-actions · 2025-11-01T22:26:55Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T22:27:14Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T22:39:09Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

The boxes in the PR description are not yet properly checked in Markdown syntax.

Sprint-2/1-key-errors/1.js

cjyuan · 2025-11-08T11:13:04Z

Sprint-2/3-mandatory-implement/1-bmi.js


 function calculateBMI(weight, height) {
+    const bmi = weight / (weight*height);
+    return bmi.toFixed(1);


What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

console.log(123); // Output 123 console.log("123"); // Output 123 // Treated differently in the program let sum1 = 123 + 100; // Evaluate to 223 -- a number let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.

I expect the function will return a number and it does return a number.

Can you look up how to check if a value is a number in JavaScript, and then apply the technique to verify your expectation?

cjyuan · 2025-11-08T11:13:46Z

Sprint-2/4-mandatory-interpret/time-format.js


 // c) What is the return value of pad is called for the first time?
-// =============> write your answer here
+// =============> 00


To more precisely express a value is a string, we can enclose the value by a pair of double quotes. For example, "00".

I have corrected my answer. thanks

Why not apply it to all the answers where it is applicable?

Sprint-2/5-stretch-extend/format-time.js

github-actions · 2025-11-08T11:20:05Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T11:20:05Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T14:17:22Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T16:26:04Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T16:26:08Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-09T04:26:08Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-09T04:26:09Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

HANISADAH added 11 commits November 1, 2025 21:59

Answering the task

15dadf1

Answering the task

c642719

Answering the task

f91a49c

Answering the task 1

a33f384

Answering the task

a734ad2

Answering the task 1 bmi

336d1b4

Answering the task 2 cases

11a298c

Answering the task 3

c14e9d7

Answering the task time-format

97da7db

Answering the task

23ddb39

Merge branch 'CodeYourFuture:main' into coursework/sprint-2

2f8ccfb

HANISADAH added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 1, 2025

cjyuan reviewed Nov 8, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2025

deleted medina.js

25bda16

HANISADAH added 4 commits November 8, 2025 15:24

Updating the task

db3249a

updating the task's answer

e03cac5

updating the answer

cb2de15

Updating the answer

6941206

HANISADAH added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 8, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 9, 2025

illicitonion closed this Jan 7, 2026

Uh oh!

Conversation

HANISADAH commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

HANISADAH Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

HANISADAH Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HANISADAH commented Nov 1, 2025 •

edited

Loading