London | 25-ITP-Sep | Payman Issa Baiglu | Sprint 1 | Coursework/sprint 1 by PaymanIB · Pull Request #811 · CodeYourFuture/Module-Structuring-and-Testing-Data

PaymanIB · 2025-10-26T14:03:49Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

in this PR: Sprint 1 Coursework completed. errors fixed and questions answered

github-actions · 2025-10-26T14:04:14Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-26T14:07:31Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sprint-1/1-key-exercises/1-count.js

cjyuan · 2025-10-26T17:23:26Z

Sprint-1/1-key-exercises/3-paths.js

-const ext = ;
+const dir = filePath.slice(0, lastSlashIndex + 1);

+const lastSlDotIndex = filePath.lastIndexOf(".");


In the variable name, lastSlDotIndex, what does Sl stand for?

I think it comes from Slice.

Variable names should be meaningful. What are you trying to describe as SlDot? Slice dot?

I would say it means the last slice after "."

Sprint-1/1-key-exercises/4-random.js

Sprint-1/2-mandatory-errors/4.js

Sprint-1/3-mandatory-interpret/1-percentage-change.js

Sprint-1/3-mandatory-interpret/2-time-format.js

Sprint-1/3-mandatory-interpret/3-to-pounds.js

cjyuan · 2025-10-26T17:38:41Z

Sprint-1/4-stretch-explore/chrome.md

 What effect does calling the `prompt` function have?
+A pop up window with the question and a place to input answer is opening. 
 What is the return value of `prompt`?
+The input value will be returned by prompt() and stored in the variable myName.


What if the user entered a value and clicked the "Cancel" button (instead of the "OK" button)?

The return value will be null for myName. meaning that no input.

What do you mean by "no input"?
What would prompt() return if the user didn't enter anything (i.e., no input) and then click "OK"?

The return will be null

null means no value entered.

What would prompt() return if the user didn't enter anything (i.e., no input) and then click "OK"?

Have you verified that prompt() returns null in this case? Because I got a different result.

Thanks for pointing that out. If cancel be clicked, the output will be null. If no value entered and OK be clicked the output will be nothing as ``.

PaymanIB · 2025-10-29T16:38:18Z

Many Thanks Cjyuan for reviewing this carefully. I do appreciate it!

cjyuan · 2025-10-29T23:20:42Z

All good. Well done.

PaymanIB · 2025-10-30T14:23:36Z

Thanks for pointing out those details and helped me learn them!

Payman IB added 8 commits October 21, 2025 11:10

1st & 2nd are completed.

c16f93f

3rd is completed

baf6383

4th completed and explained.

a1bcfd7

Errors are fixed and explained for exercise 2.

8ddf08f

1-percentage-change completed => questions are answered.

74687a6

sprint 1- mandatory-interpret 1 & 2 completed

8257fa0

Chrome .md completed

2a33fa1

Sprint-1/Objects.md completed

870693a

PaymanIB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 26, 2025

cjyuan reviewed Oct 26, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

Payman IB added 2 commits October 29, 2025 16:10

Lines 26 & 43 updated.

f8a6510

Line 20, error fixed

bc21da9

PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025

PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025

PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025

illicitonion closed this Jan 7, 2026

Uh oh!

Conversation

PaymanIB commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PaymanIB commented Oct 29, 2025

Uh oh!

cjyuan commented Oct 29, 2025

Uh oh!

PaymanIB commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PaymanIB commented Oct 26, 2025 •

edited

Loading