Glasgow| 25-ITP-Sep | Abraham-Habte| Sprint 3|Coursework/sprint-3-implement-and-rewrite#806
Closed
Abrsh100 wants to merge 7 commits intoCodeYourFuture:mainfrom
Closed
Conversation
Abrsh100
added
the
Needs Review
LonMcGregor
reviewed
Oct 27, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
| if (numerator > denominator) { | ||
| return false; | ||
| } | ||
| if (numerator === denominator) { |
There was a problem hiding this comment.
Are you certain this implementation is correct? Check what the comment for the test case for this condition says
| }); | ||
| // Case 5: Handle Invalid Cards: | ||
| test("should return null for invalid card 'B'", () => { | ||
| expect(getCardValue("Z♠")).toBeNull(); |
There was a problem hiding this comment.
Is there maybe a better jest test to use here? Looking at the documentation, can you see any expect() options that would work to help test for exceptions being thrown?
LonMcGregor
added
Reviewed
Abrsh100
added
Needs Review
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have done all the tasks required for this sprint
Questions
No questions