London | 25-ITP-Sep | Shaghayegh Shirinfar | Sprint 3 | practice-tdd

[shaghayeghfar]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

[jennethydyrova]

hi @shaghayeghfar! You have two PRs (this and #789) with almost same content. Could you please close one of them if the work is repeated in both PRs

[shaghayeghfar]

Dear @jennethydyrova,

thank you for my checking PR.

I didn't realize that Sprint 3 had two parts of the exercise that should have been done in separate pull requests. Initially, I pushed some of the work for both parts into the same PR by mistake. Once I noticed, I made small changes in each file and submitted them as two separate pull requests as requested in the Sprint 3 backlog. Sorry for any inconvenience caused.
Since I need both links for my submission, could you please advise me on what I should do?

many thanks for your help and time, I really appreciate it.

[jennethydyrova]

No worries! Just make sure to remove any duplicate or overlapping code, so each PR contains only the unique changes that need to be reviewed.

[shaghayeghfar]

Dear @jamesbaskerville
deleted some files from the changes in GitHub. I’m not entirely sure if I did it correctly since I’m still a beginner with GitHub. Could you please check it for me and advise me? Thank you!

[jennethydyrova]

@shaghayeghfar I think you tagged someone else but I received a notification as I left comments here before. Your PR still looks quite cluttered but that might because you didn't push changes because I don't see any recent commits.

[shaghayeghfar]

@jennethydyrova
Dear Jennet
Thank you for reviewing my pull request. I realized that instead of creating a new branch from the main branch, I accidentally created it from wherever I was in Git at the time. This made things a bit messy and incorrect.

I’ve now created a clean branch and another PR so will close this pull request.

Thank you for your time and help!