Birmingham | 25-ITP-Sep | Joy Opachavalit | Sprint 2 | coursework/sprint-2#774
Closed
enjoy15 wants to merge 15 commits intoCodeYourFuture:mainfrom
Closed
Birmingham | 25-ITP-Sep | Joy Opachavalit | Sprint 2 | coursework/sprint-2#774enjoy15 wants to merge 15 commits intoCodeYourFuture:mainfrom
enjoy15 wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
enjoy15
added
📅 Sprint 2
a-robson
added
the
Review in progress
a-robson
reviewed
Oct 21, 2025
a-robson
left a comment
a-robson
left a comment
There was a problem hiding this comment.
Great job. You show a solid grasp of some Javascript fundamentals and your explanations are clear. There is just the one issue to address.
Comment on lines
+25
to
+34
| function toPounds (penceString) { | ||
| const penceStringWithoutTrailingP = penceString.substring(0, penceString.length - 1); | ||
| const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); | ||
| const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2); | ||
| const pence = paddedPenceNumberString | ||
| .substring(paddedPenceNumberString.length - 2) | ||
| .padEnd(2, "0"); | ||
| return `£${pounds}.${pence}`; | ||
| } | ||
| console.log(toPounds("399p")); |
There was a problem hiding this comment.
Nice work. However you should test the function with a number of different inputs. Thinking about different cases helps us make our code more robust. Can you add some examples of typical uses of the function? You might also like to think about types of input that the function won't handle well.
Author
There was a problem hiding this comment.
Added more examples of typical uses of the function and types of input that the function won't handle well.
There was a problem hiding this comment.
Excellent. Good work on the edge cases. I'll mark this review 'Complete'.
a-robson
added
Reviewed
enjoy15
added
the
Needs Review
a-robson
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
#Changelist
-Completed all excercises in Sprint-2