generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 413
London | 26-ITP-JAN | Kayanat Suleman | Sprint 1 | Wireframe #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KayanatSuleman
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
KayanatSuleman:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−43
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7a56285
Create three articles explaining README, wireframes, and Git branches
KayanatSuleman 99c4e3f
Fix broken article tags in wireframe page
KayanatSuleman 2809de5
Add external links to each article
KayanatSuleman 2be4de3
Replace placeholder summaries with wireframe and Git branch descriptions
KayanatSuleman 07f9474
Fix footer css sytnax and pin footer to bottom
KayanatSuleman 7e05e34
Updating article summaries and page descriptions, implementing semati…
KayanatSuleman 601a89d
Cross checking success critiera and objectives met, including a light…
KayanatSuleman 2824c47
updating obstructing paragraph within footer for easily readibility
KayanatSuleman 0c82ff5
Merge upstream main into feature/wireframe
KayanatSuleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,47 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| This page explains key concepts used in web development, including README files, wireframes, and Git branches. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| </header> | ||
| <main> | ||
| <section> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>What is the purpose of a README file?</h2> | ||
| <p> | ||
| A ReadMe file explains what a project is, how to set it up and how to use it. | ||
| </p> | ||
| <a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes" target="_blank" rel="noopener noreferrer">Learn more about READMEs</a> | ||
| </article> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>What is the purpose of a wireframe?</h2> | ||
| <p> | ||
| A wireframe is a simple visual guide that shows the layout and structure of a webpage before it is built. | ||
| </p> | ||
| <a href="https://balsamiq.com/blog/what-are-wireframes/" target="_blank" rel="noopener noreferrer">Learn more about wireframes</a> | ||
| </article> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>What is a branch in Git?</h2> | ||
| <p> | ||
| A Git branch allows developers to work on new features or fixes independently without affecting the main codebase. | ||
| </p> | ||
| <a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell" target="_blank" rel="noopener noreferrer">Learn more about Git branching</a> | ||
| </article> | ||
| </section> | ||
| </main> | ||
| <footer> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kayanat,
I noticed that there are a few differences between your page and the wireframe. Try to view your page and the wireframe side-by-side and spot the differences.
I noticed that your page is missing a footer, and that all of the cards are the same size.