-
-
Notifications
You must be signed in to change notification settings - Fork 409
Sheffield | 26-ITP-Jan | Hayriye_Saricicek | Sprint 1 | Wireframe #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sheffield | 26-ITP-Jan | Hayriye_Saricicek | Sprint 1 | Wireframe #1052
Conversation
❌ Deploy Preview for cyf-onboarding-module failed. Why did it fail? →
|
|
Your webpage could not be deployed on Netlify properly, and I think the failure is related to the image file size. Can you try removing the three JPEG images from your repo and just use the |
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start, but the main purpose of implementing a wireframe is to translate structure and functionality, not final visual design. Visual design is usually handled by UI/graphic designers after the wireframe phase. To better align with the wireframe, here are a few areas where the layout and appearance could be refined:
- Your page does not have a subtitle (in the wireframe image, under the "PAGE TITLE" there is a "A SHORT DESCRIPTION" subtitle)
- In the wireframe image, the title, text content, and the READ MORE link of the first article are left aligned instead of centered.
- In the wireframe image, all articles have a visible border.
2
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask an AI tool what that requirement means).
| <figcaption>Wireframe group planning session</figcaption> | ||
| </figure> | ||
| <h2>What is a Wireframe?</h2> | ||
| <p> A wireframe is a basic, skeletal blueprint of a website, app, or digital product, showing the layout, structure, and placement of elements like text, images, and buttons, but without detailed visual design (colors, fonts). It acts as a roadmap for user experience (UX) and functionality, helping teams align on structure and flow early in the design process, focusing on "what" goes "where" before diving into "how it looks". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 20 can be better formatted as:
<p>
A wireframe is a basic, skeletal blueprint of a website, app, or digital product,
showing the layout, structure, and placement of elements like text, images,
and buttons, but without detailed visual design (colors, fonts). It acts as a
roadmap for user experience (UX) and functionality, helping teams align on
structure and flow early in the design process, focusing on "what" goes "where"
before diving into "how it looks".
</p>
To understand why, you can ask AI these questions:
- How HTML treats multiple whitespace characters in text?
- What's the advantage of not writing a long paragraph of text in a single line in HTML?
VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text.
To use the feature, right-click inside the code editor and select the option.
Please note that if there are syntax errors in the code, the "Prettier" extension may not format HTML code properly.
Self checklist
Changelist
I have added articles with images and links to my wireframe.