Skip to content

Conversation

@ihortar
Copy link

@ihortar ihortar commented Jan 24, 2026

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Semantic HTML tags are used to structure the webpage.
  • The page scores 100 for Accessibility in the Lighthouse audit.
  • The page header includes a title and description.
  • The articles section has three unique articles, each including a title, summary, and a link.
  • The page footer is fixed to the bottom of the viewport.
  • The webpage is styled using a linked .css file.
  • The webpage is properly committed and pushed to a branch on GitHub.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 6492f17
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974b2530a88a20008beee80
😎 Deploy Preview https://deploy-preview-1037--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 98 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@ihortar ihortar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@ihortar ihortar marked this pull request as ready for review January 24, 2026 11:52
@jenny-alexander jenny-alexander self-requested a review February 1, 2026 00:04
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 1, 2026
Copy link
Contributor

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi @ihortar - thank you for submitting this PR for the wireframe exercise. The webpage correctly shows most of the exercise requirements. However, there are some code improvements to be made.

  • Can you run your deployed page through W3 validator? This will give you a list of errors you can fix. If you aren't sure what an error means, you can search online or you AI (chatGPT, etc).
  • Can you review the wireframe image from the onboarding exercise? Notice where the page title and description are aligned. Can you make your page look like this?
  • The 'Read more' button for the wireframe article take me to a page that doesn't exist. Can you review this?
  • The alt text attribute for an <img> tag serves an important purpose. Can you ensure your images have alt text defined? Here is a useful article about alt text: https://www.w3schools.com/tags/att_img_alt.asp.
  • The lighthouse score for your webpage is 92. Can you see what needs to be done to make it 100?

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants