Skip to content

Conversation

@bytesandroses
Copy link
Member

Checklist:

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist:

  1. Added material related to wireframes, namely:
  • What is the purpose of a README file?
  • What is the purpose of a wireframe?
  • What is a branch in Git?
  1. Styled CSS using reference wireframe provided.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit f28d7c3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697c72ae82a99600080daa4d
😎 Deploy Preview https://deploy-preview-1032--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@bytesandroses bytesandroses changed the title Cape Town | 2026-ITP-Jan | Isaac Abodunrin | Onboarding Sprint 1 | Wireframe to Web Code Cape Town | 2026-ITP-Jan | Isaac Abodunrin | Sprint 1 | Wireframe to Web Code Jan 24, 2026
@bytesandroses bytesandroses marked this pull request as ready for review January 24, 2026 00:16
@bytesandroses bytesandroses added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

When I asked AI to check the page for typo and possible improvements, it showed me one grammar mistake and some possible improvements.

Can you try that too and further improve your work based on the AI feedback?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 29, 2026
@bytesandroses
Copy link
Member Author

Thanks for the helpful feedback @cjyuan!

I've used Google Gemini to check the page as suggested. It picked up the grammatical error and gave some suggestions.

Here's a summary of the changes that were made:

  1. Corrected typo/grammatical errors
  2. Improved accessibility
  3. Improved readability
  4. Improved overall flow of page (more descriptive title and subtitle)
  5. Tidy up the code (removing an unused class and defining the color variable in CSS)

@bytesandroses bytesandroses added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 30, 2026

Well done!

@cjyuan cjyuan removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 30, 2026
@cjyuan cjyuan added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants