Skip to content

Conversation

@MehrozMunir
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have created a form using html to get inputs from the user including their name, email, color and size of the shirt they want. And a submit button.

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 49e0184
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6973cd965a40db0008d76261
😎 Deploy Preview https://deploy-preview-1030--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@MehrozMunir MehrozMunir added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels Jan 23, 2026
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 31, 2026
@jenny-alexander jenny-alexander self-requested a review January 31, 2026 23:52
@jenny-alexander
Copy link
Contributor

Hi @MehrozMunir, your form controls exercise is done very well. The form validation works nicely and you have used semantic HTML. I think the use of <p> is a little bit excessive but you most likely did this for styling purposes. Since CSS can't be used for styling, I'll let this pass. 🙂

I left a few comments in the code. Please have a look.

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants