Fix: File downloads and opens used wrong API URL#471
Open
amahuli03 wants to merge 2 commits intoCodeForPhilly:developfrom
Open
Fix: File downloads and opens used wrong API URL#471amahuli03 wants to merge 2 commits intoCodeForPhilly:developfrom
amahuli03 wants to merge 2 commits intoCodeForPhilly:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I fixed the API URL path in
handleDownloadinListOfFiles.tsx. It was missing the/apiprefix specified inbalancer_backend/urls.py, so file downloads were resulting in 400 error.While looking into this error I also found that
handleOpeninListOfFiles.tsxused the same wrong URL.handleOpenis called from the Help/DataSources page and, as expected, was resulting in 400 errors when I tried to view the files. The same fix ashandleDownloadfixed this issue, and this View button acts as expected now.Related Issue
https://codeforphilly.slack.com/archives/C059A5JHX8X/p1772128435712889
Manual Tests
Locally tested file downloads, which now successfully download the real PDF.
Locally tested file opens from the Help/DataSources page, which now successfully open the PDF in a new tab.
Reviewers
@sahilds1