Fix: duplicate healthcheck key in docker-compose db service#462
Open
amahuli03 wants to merge 2 commits intoCodeForPhilly:developfrom
Open
Fix: duplicate healthcheck key in docker-compose db service#462amahuli03 wants to merge 2 commits intoCodeForPhilly:developfrom
amahuli03 wants to merge 2 commits intoCodeForPhilly:developfrom
Conversation
Collaborator
|
lgtm Cc. @sahilds1 |
amahuli03
changed the title
…-healthchecks-docker-compose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a duplicate
healthcheckkey indocker-compose.ymldb service section. I deleted one of thehealthcheckkeys.I kept the one with a 10s interval to stay consistent with the rest of the builds, but we can definitely adjust this if needed.
Related Issue
N/A: Dicussed with @TineoC in chat
Manual Tests
docker compose up --buildsuccessfully builds nowAutomated Tests
No automated tests were added since this change only affects Docker configuration
Documentation
no documentation updates required.
Reviewers
@TineoC
Notes