Update CONTRIBUTING.md #32
Conversation
aedwardg
requested review from
Cykotech,
Jamesllllllllll,
Superspork002,
Victoria-DR and
ashstewart7
ashstewart7
left a comment
ashstewart7
left a comment
There was a problem hiding this comment.
Awesome - just a couple tiny suggestions/things for discussion :)
| - If you become a regular contributor, you may request to be added as a collaborator on the project so that you can work from a direct clone rather than a fork. | ||
| - Name your feature branch something descriptive of your task. Including the issue number is common practice. | ||
| - For example, if you are working on issue number 42 and performing a refactor on the navbar component, a good branch name would be `42-refactor-navbar-component`. | ||
| - Ensure that your code works, tests pass and your code is properly linted and formatted prior to opening a PR. |
There was a problem hiding this comment.
Might be worth adding that, once a PR is created and the user is happy with it, to formally request review from @\CodeCafeCommunity/website?
There was a problem hiding this comment.
Or create a discord channel specifically for contributors. And assign a role only when someone has actively taken on an issue. I don't know if that can be done with an automatic process.
There was a problem hiding this comment.
Ooh neat, I think we'd probably have to do it manually, but I agree with having a channel.
There was a problem hiding this comment.
I definitely like the idea of having a dedicated channel and Contributor role in the discord server! I think maybe they should receive the role after having a PR merged in. Once we have that set up we can add a section about it to this document
What issue is this solving?
Closes #29
Description
Add initial contribution guidelines for all contributors, as well as maintainers.
Any helpful knowledge/context for the reviewer?
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Please make sure you've attempted to meet the following coding standards