Skip to content

Conversation

@Cykotech
Copy link
Contributor

What issue is this solving?

Closes #28

Description

Created a simple mockup to begin a design for a home page and establish the theme of the community site. Everything is self contained in the new mockup directory.

I wasn't super picky just wanted to get quick concept on the web page. I leaned a little bit more into using the colors from the Discord logo a bit to experiment. I think a lot of things will be easier to fine tune when we implement the color scheme in Tailwind or even use HSL over hex colors.

Any helpful knowledge/context for the reviewer?

image
image

Feelings gif (optional)

alt text

Please make sure you've attempted to meet the following coding standards

  • Code has been tested and does not produce errors
  • Code is readable and formatted
  • There isn't any unnecessary commented-out code

@Cykotech
Copy link
Contributor Author

The empty span in the header is for the purpose of me not feeling like screwing around with centering the navbar and I felt as if there could be some user avatar there potentially.

@Jamesllllllllll
Copy link
Contributor

  • Converted @Cykotech's mockup to React components & tailwind classes.
  • Needs to be adapted to a Layout/Children pattern

@Jamesllllllllll
Copy link
Contributor

Layout implemented!

Copy link
Member

@ashstewart7 ashstewart7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - let's hold off merging the code changes for the time until we've had more pairs of eyes on the design though 😄

@Jamesllllllllll
Copy link
Contributor

Nice - let's hold off merging the code changes for the time until we've had more pairs of eyes on the design though 😄

Yes! I think the colour scheme can be improved.

@aedwardg
Copy link
Collaborator

I love the enthusiasm, and I think this is a great start!
That said, I don't think this PR is (or was ever intended to be) merge-able.

In the future, let's try to keep experiments like this in Draft PRs, and spin up additional branches with changes if we want to build off each others' ideas

@Jamesllllllllll
Copy link
Contributor

In the future, let's try to keep experiments like this in Draft PRs, and spin up additional branches with changes if we want to build off each others' ideas

Thanks for that tip! I didn't think about branching off a branch. My enthusiasm ran away with me 😂

@aedwardg
Copy link
Collaborator

aedwardg commented Dec 30, 2024

In the future, let's try to keep experiments like this in Draft PRs, and spin up additional branches with changes if we want to build off each others' ideas

Thanks for that tip! I didn't think about branching off a branch. My enthusiasm ran away with me 😂

All good! Better to have people excited for a project than lack-luster! 😄

@Cykotech Cykotech closed this pull request by merging all changes into main in e7009f8 Jan 16, 2025
@Cykotech Cykotech deleted the mockup-design branch January 16, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page Design

5 participants