Skip to content

Conversation

@Jamesllllllllll
Copy link
Contributor

@Jamesllllllllll Jamesllllllllll commented Dec 27, 2024

What issue is this solving?

Closes #14

Description

  • Added .nvmrc and .node-version files to use node version 23.5.0.
  • Added node version file to GH actions
  • Updated readme to reflect node version and install & dev scripts

Any helpful knowledge/context for the reviewer?

I think this will not enforce the node version in development. Not sure if we want to!

Feelings gif (optional)

Not sure

Please make sure you've attempted to meet the following coding standards

  • Code has been tested and does not produce errors
  • Code is readable and formatted
  • There isn't any unnecessary commented-out code

Copy link
Contributor

@Cykotech Cykotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@aedwardg aedwardg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can also mark that this PR closes #7

@Jamesllllllllll Jamesllllllllll merged commit 82f1ba4 into main Dec 27, 2024
2 checks passed
@Jamesllllllllll Jamesllllllllll deleted the enhancement/node-version branch December 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .nvmrc and .node-version files

5 participants