Skip to content

Comments

Fix Conversion Error with Union#27

Merged
PenguinBoi12 merged 3 commits intomainfrom
fix-argument-conversion
Feb 16, 2026
Merged

Fix Conversion Error with Union#27
PenguinBoi12 merged 3 commits intomainfrom
fix-argument-conversion

Conversation

@PenguinBoi12
Copy link
Contributor

@PenguinBoi12 PenguinBoi12 commented Feb 16, 2026

This PR fixes a problem with converting command arguments that are unions. It also add missing test that should have catch that.

Before After
image image image

@PenguinBoi12 PenguinBoi12 added the bug Something isn't working label Feb 16, 2026
@PenguinBoi12 PenguinBoi12 force-pushed the fix-argument-conversion branch from 02a115f to 702e85b Compare February 16, 2026 03:25
@PenguinBoi12 PenguinBoi12 force-pushed the fix-argument-conversion branch from 702e85b to 0d89378 Compare February 16, 2026 03:26
@chrisdedman chrisdedman self-requested a review February 16, 2026 03:29
Copy link
Contributor

@chrisdedman chrisdedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM

@PenguinBoi12 PenguinBoi12 merged commit 40ac8c7 into main Feb 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants