Conversation
…uler jobs, and embed notifications
Collaborator
Author
|
@PenguinBoi12 I have the unit test to write, but I will once we agree that this implementation logic is good. edit: I went ahead and built a unit test. I think, regardless of the logic, the return value should be the same, so it can be tested. |
…minder command behavior - Add tests/extensions/test_reminder_cog.py - Verify timer parsing for valid and invalid formats - Assert _build_timer returns timedelta and _build_embed returns Embed - Test reminder command success and failure paths using AsyncMock/fixtures
PenguinBoi12
requested changes
Oct 19, 2025
Contributor
PenguinBoi12
left a comment
PenguinBoi12
left a comment
There was a problem hiding this comment.
The feature is well built but the test could be improved.
PenguinBoi12
approved these changes
Oct 23, 2025
Contributor
PenguinBoi12
left a comment
PenguinBoi12
left a comment
There was a problem hiding this comment.
Looks good, that's an awesome feature. Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented a ReminderCog that allows users to set reminders with customizable timers. The implementation includes timer parsing, scheduling jobs, and sending notifications via embedded messages.
This PR resolves the issue #116
Usage
with the slash command:
Without the slash command:
Available characters time for reminder are
s=second,m=minutes,h=hour,d=dayDemo