Some Animations for Landing Page using GSAP.#7
Some Animations for Landing Page using GSAP.#7akshprooo wants to merge 2 commits intoCode-Society-Lab:mainfrom
Conversation
|
Can you please send a screen recording of the changes and list in the PR everything that you added, in this case, all the animations. Also, next time you find a bug, you don't have to open a new PR. You can just push the changes and it will update the PR. It's easier to track changes that way. |
There was a problem hiding this comment.
I’ve only reviewed the code so far, and at a quick glance it looks good overall, there's just a few things that should be removed. I still need to test the behavior to confirm everything works as expected and that the website is still fast and snappy.
| <!-- Custom Javascript --> | ||
| <script src="./javascript/script.js"></script> | ||
|
|
||
| <!-- <script> |
There was a problem hiding this comment.
Please remove unused code.
| autoRaf: true, | ||
| }); | ||
|
|
||
| lenis.on('scroll', (e) => { |
There was a problem hiding this comment.
Feels like it was there for debugging. Please remove it.
| }); | ||
| </script> | ||
| <!-- Custom Javascript --> | ||
| <script src="./javascript/script.js"></script> |
There was a problem hiding this comment.
nit: You don't need the ./ at the beginning.
2 participants
added some animations, and solved the bug from the last pull request.