Skip to content

Conversation

@RahulHarihar
Copy link
Contributor

Cleanup: test/auth-signup-validation branch formatting fixes

Description

This PR cleans up the test/auth-signup-validation branch by removing unnecessary formatting noise, including tab-to-space corrections and consistent use of single quotes in imports. No functional changes were made to the code or tests.

Related Issue

Addresses previous PR #16 and cleanup comment; original issue #7

Motivation and Context

The previous PR included formatting changes (tabs, quotes) that made reviewing the actual test logic difficult. This cleanup makes the diff focused only on meaningful changes, improving readability and maintainability.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an existing feature)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test (adds or updates tests only)
  • Documentation (non-code change)

How Has This Been Tested?

  • Ran the existing test suite to ensure all tests still pass.
  • Verified that only formatting was changed and no functionality was affected.

Screenshots (if applicable):

Not applicable (backend test files only).

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes (existing tests updated for readability)
  • All new and existing tests passed

@netlify
Copy link

netlify bot commented Oct 1, 2025

Deploy Preview for paisable ready!

Name Link
🔨 Latest commit 563e56c
🔍 Latest deploy log https://app.netlify.com/projects/paisable/deploys/6904f8afb45a8d0008ba11bb
😎 Deploy Preview https://deploy-preview-46--paisable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94
Accessibility: 100
Best Practices: 100
SEO: 91
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@RahulHarihar
Copy link
Contributor Author

RahulHarihar commented Oct 1, 2025

Hey @archa8, Thanks for your feedback on the previous PR! I’ve cleaned up the branch, so this new PR only includes the essential code and test changes.

Also, could you please add the 'hacktoberfest' label to this issue? That would be helpful.

Appreciate your review!

@RahulHarihar RahulHarihar changed the title Test/auth signup validation cleanup #16 Test/auth signup validation cleanup Oct 1, 2025
@archa8 archa8 linked an issue Oct 3, 2025 that may be closed by this pull request
Copy link
Member

@archa8 archa8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly delete the package.json, package-lock.json (from the root) and .env from the frontend folder. Rest is fine

Copy link
Member

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep your editor code spacing from 4 to 2-space indentation.
It's very hard to review your changes, and it aligns with the project's formatting standards.

@RahulHarihar
Copy link
Contributor Author

@archa8 I’ve removed the requested files from the root and frontend folders and also applied the changes requested by @Avdhesh-Varshney. I’d appreciate it if you could review the updates. Your feedback would be very helpful.

@RahulHarihar
Copy link
Contributor Author

Hey @archa8, I’ve made the requested changes. Just wanted to check if you’ve had a chance to review them yet.

Copy link
Member

@archa8 archa8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@archa8 archa8 removed the request for review from Avdhesh-Varshney October 31, 2025 15:07
@RahulHarihar
Copy link
Contributor Author

@archa8 thank you, @Avdhesh-Varshney your review?

Copy link
Member

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contribution 🎉
Keep hacking & keep learning!

@archa8 archa8 merged commit 066b17e into Code-A2Z:master Oct 31, 2025
4 checks passed
@RahulHarihar
Copy link
Contributor Author

@Avdhesh-Varshney Thanks for merging! Appreciate the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: User signup with an existing email

3 participants