containerized the application #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@archa8 Please review the pr |
Contributor
Author
|
@archa8 any issues or improvements regarding the pr .? |
archa8
reviewed
Oct 21, 2025
Member
archa8
left a comment
archa8
left a comment
There was a problem hiding this comment.
Hey @MukeshAbhi, thank you for opening the PR. I am not well-versed with Docker, but won't the Nginx configuration for the frontend cause problems? Like while hitting refresh on a page, there might be file not found problems. For that you might need to create a .conf file for Nginx. Let me know what you think
Contributor
Author
|
@archa8 Yes you are right I will update the docker file. |
Contributor
Author
|
@archa8 I have added nginx.conf and updated the docker file. Please review the pr. |
Contributor
Author
|
@archa8 any issues or improvements regarding the pr .? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Dockerize Frontend and Backend with Docker Compose #139
Description
This pull request adds Docker support to the project for easier setup and consistent development environments.
Changes
Dockerfilefor the backend service usingnode:16-alpine.Dockerfilefor the frontend:node:18-alpine.nginx:alpine.docker-compose.ymlto orchestrate backend, frontend, and database services.