-
Notifications
You must be signed in to change notification settings - Fork 78
UI/UX Improvement for Authentication Pages #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enhances the authentication UI/UX for Login and Register pages with modern styling, better visual hierarchy, and interactive elements like icons and loading states.
- Adds loading states and improved error presentation on Login and Register forms
- Introduces password strength indicators and requirement checklist on Register page
- Refactors PasswordInput to accept custom className and adds accessibility improvements for the visibility toggle
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| frontend/src/pages/RegisterPage.jsx | Adds new layout, email icon, password strength meter, and loading/disabled submit handling |
| frontend/src/pages/LoginPage.jsx | Adds new layout, email icon, loading/disabled submit handling, and improved error presentation |
| frontend/src/components/PasswordInput.jsx | Extends API to accept className, tweaks styling composition, and improves accessibility for the eye toggle |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @yasirakhlaque, it looks very nice and works as intended. However, there are some suggestions by Copilot in your code, which I think you should take a look at. |
archa8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the Copilot suggestions
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@archa8 Yes I have taken a look at the copilot reviews and they are really good so I have merged them into my code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
archa8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!

Description
This Pull Request introduces significant user interface and user experience enhancements to the Login and Register pages, as shown in the attached screenshots. The goal was to create a more modern, intuitive, and visually appealing authentication flow for users of Paisable.
Key visual changes include:
Related Issue
Fixes #130
Motivation and Context
This change is required to modernize the look and feel of the application's most visible entry points. The improvements solve problems related to visual appeal, clarity, and overall professionalism, ensuring a positive first impression for new and returning users.
Types of Changes
How Has This Been Tested?
The changes were primarily tested via local development by:
Screenshots (if applicable):
Checklist