feat: Add Native Support for OpenCore-style Recovery DMG Booting #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EMPLATE_bug_report.md
…SUE_TEMPLATE_feature_request.md
…ISSUE_TEMPLATE/bug_report.md
Fix directory handling in clone_OpenCorePkg
…os-scripts Add shebang and error handling to test scripts
- Implements detection and boot entry creation for BaseSystem.dmg in com.apple.recovery.boot - Automatically injects 'root-dmg' boot argument for Recovery DMG entries - Fixes circular dependency in Hibernate.h with forward declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces native support for booting macOS Recovery directly from BaseSystem.dmg located in the
com.apple.recovery.bootdirectory, similar to the method used by OpenCore. This feature eliminates the need to restore the DMG to a dedicated HFS+ partition, simplifying the creation of USB installers and recovery drives, especially for users creating media from Windows/Linux.Changes
rEFIt_UEFI/entry_scan/loader.cpp:
\com.apple.recovery.boot\.root-dmgboot argument (e.g.,root-dmg=file:///com.apple.recovery.boot/BaseSystem.dmg) for these specific entries. This ensures the kernel correctly mounts the DMG as the root device during boot.boot.efirecovery.rEFIt_UEFI/Platform/Hibernate.h:class LOADER_ENTRYto resolve a circular dependency issue encountered during compilation with newer toolchains (e.g., Xcode 16 / GCC 15).Motivation
Currently, Clover requires extracting the Recovery DMG content to a partition for it to be bootable. This enhancement modernizes Clover's capabilities by leveraging the existing OpenCore integration logic (already present in
main.cppviaInternalLoadDmg) to support direct DMG loading.Testing
BaseSystem.dmgon a FAT32 partition.root-dmgargument is correctly passed to the kernel, resolving "Waiting for Root Device" errors without user intervention.Notes
Code style follows existing project conventions.
This feature relies on the
BaseSystem.chunklistfile being present alongside the DMG, which is standard behavior for Apple's recovery images.Contributed by @hnanoto