-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: 💡 reconcile file and multiple file upload #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… upload and multi file upload
refactor: 💡 create hook for drag and drop
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f639a35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EvandroLG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted a small bug in the cleanup. Fixing it, we should be good to go.
Why?
Reconcile FileUpload and FileMultiUpload to prevent and reduce concurrent implementations, e.g. behaviour, features, styles, etc.
In the previous version, the multiple-file-upload component recreated the file upload in its file context, which was prone to errors.
How?
Preview?
demo-shared-file-upload-multi-upload.mov