Skip to content

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Feb 3, 2026

Why?

Reconcile FileUpload and FileMultiUpload to prevent and reduce concurrent implementations, e.g. behaviour, features, styles, etc.

In the previous version, the multiple-file-upload component recreated the file upload in its file context, which was prone to errors.

How?

  • Split shared features to separate files, e.g. file upload area, drag and drop hook
  • Create reusable types

Preview?

demo-shared-file-upload-multi-upload.mov

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
click-ui Ready Ready Preview, Comment Feb 11, 2026 6:09pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

🦋 Changeset detected

Latest commit: f639a35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@punkbit punkbit marked this pull request as ready for review February 3, 2026 17:29
@gjones gjones requested a review from vineethasok February 3, 2026 20:02
Copy link
Collaborator

@EvandroLG EvandroLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted a small bug in the cleanup. Fixing it, we should be good to go.

@punkbit punkbit merged commit d3b40ae into main Feb 11, 2026
6 checks passed
@punkbit punkbit deleted the refactor/file-multiple-upload-use-file-upload branch February 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants