-
Notifications
You must be signed in to change notification settings - Fork 0
Fix toctree hierarchy for chipflow-lib documentation #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📖 Documentation Preview✅ Preview is live! Built from commit 2e7a190 |
73032cb to
97677fd
Compare
📖 Documentation Preview✅ Preview is live! Built from commit c86e886 |
97677fd to
69b6e56
Compare
📖 Documentation Preview✅ Preview is live! Built from commit 83a3ab4 |
69b6e56 to
506eab1
Compare
📖 Documentation Preview✅ Preview is live! Built from commit 56055de |
📚 Documentation ReviewLet me just provide the review directly to you: SummaryThe ChipFlow documentation is well-structured and comprehensive, covering getting started guides, examples, and reference documentation. However, there are critical inconsistencies in command syntax between different sections that would confuse users, plus some missing vendor documentation directories and minor terminology issues. Issues FoundCritical1. Command Syntax Inconsistency - Examples vs Tutorial The most serious issue: three different command formats are used across the documentation:
Impact: Users won't know which commands are correct, leading to failures. Files affected:
2. Missing Vendor Documentation Directories The index.rst references Impact: Broken links when viewing raw documentation; dependency on build process. 3. Cross-References to Non-Existent Files docs/source/examples/getting-started.rst:130-131 links to:
These files don't exist until build time. Major4. Python Version Requirement Inconsistency
Correct requirement should be: Python 3.11 or 3.12 5. Terminology Inconsistency: System-on-Chip
Minor inconsistency in capitalization/hyphenation. 6. Email Typo in Project Metadata pyproject.toml:5 shows "rob.tayloe@chipflow.io" (likely should be "rob.taylor@chipflow.io") 7. Tutorial May Reference Old Project Structure tutorial-intro-chipflow-platform.rst uses different commands than the examples docs, suggesting it may be outdated. Minor8. README vs CLAUDE.md Command Discrepancy
Both work with PDM, just inconsistent. 9. Potentially Broken Internal Reference tutorial-intro-chipflow-platform.rst:249 uses 10. Unexplained Command examples/getting-started.rst:45 shows 11-12. Minor formatting issues with URLs and screenshot numbering RecommendationsTop 5 Actionable Improvements
Strengths
The documentation has excellent foundational content but needs immediate attention to command standardization to prevent user confusion. This review was automatically generated by Claude Code |
506eab1 to
bca003d
Compare
📖 Documentation Preview✅ Preview is live! Built from commit d251aa1 |
- Fix heading levels in chipflow-toml-guide.rst: project_name, clock_domains, process, and package now use ^^^ instead of === so they appear as subsections under their parent sections instead of top-level entries - Rename "Intro to chipflow.toml" to "chipflow.toml Reference" for clarity - Platform API Reference now properly nested under ChipFlow Library Documentation These fixes are applied via post-processing in copy_docs.py since the source files come from the vendor repo. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bca003d to
d84706c
Compare
📖 Documentation Preview✅ Preview is live! Built from commit 0c01b73 |
Summary
chipflow-toml-guide.rstso config options appear as subsectionsusing-pin-signatures.rstto link to API docsProblem
The toctree was showing incorrect hierarchy:
project_name,clock_domains,process,packageappeared as top-level entriesReferences to classes like
UARTSignature,GPIOSignature,IOTripPointwere plain text instead of links to the API documentationSolution
Added post-processing in
copy_docs.pyto fix issues after copying from vendor:===underlines to^^^for config option headings`UARTSignature()`to proper Sphinx cross-references like:py:class:~chipflow.platform.UARTSignature``Result
🤖 Generated with Claude Code