[ENG-9727] unable to create new version of a preprint when registration field has content #11492
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkovalua
force-pushed
the
fix/ENG-9727
branch
from
ad2daf2 to
ecd3ede
Compare
…flow it looks to be impossible 'why_no_prereg' be empty and 'prereg_links' exists simultaniously)
mkovalua
force-pushed
the
fix/ENG-9727
branch
from
ecd3ede to
4bb3a42
Compare
Contributor
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When attempting to create a new version of a preprint, user received the following error message:
"You cannot edit this statement while your prereg links availability is set to true or is unanswered."
Example:
https://osf.io/preprints/psyarxiv/jkfsx_v1
User has https://osf.io/preprints/psyarxiv/jkfsx_v1 linked in the prereg section of the preprint
When user goes to either edit or create new version they receive the same error message. User is unable to adjust any settings leads me back to the same error message. User tried multiple browsers and logging in/out.
Support team was unable to reproduce on test.
Changes
check prereg_links exists before raising exception (for current workflow it looks to be impossible 'why_no_prereg' be empty and 'prereg_links' exists simultaniously)
for now
we can have either
why_no_preregorhas_prereg_linksandprereg_linksset simultaniouslyand it is impossible to set all the records like it for record https://osf.io/preprints/psyarxiv/jkfsx_v1 and maybe some other records
QA Notes
Not succeeed to reproduce the issue for staging
have tried to hardcode preprint antributes that is for https://osf.io/preprints/psyarxiv/jkfsx_v1 on local testing
c524-6c06-4c9e-a837-ad5933bb2d8f.1.1.mp4
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9727