[ENG-9756] fix(addons): Show connected addon icon after oauth

[futa-ikeda]

• Ticket: [ENG-9756]
• Feature flag: n/a

Purpose

• Show addon icon after connecting an addon via oauth

Summary of Changes

• Short explanation: Preserve iconUrl from the existing authorized-storage-addon when connecting a new addon via OAuth
• Long, and entirely unnecessary explanation:
  • The icon shown in the addon card depends on the included external-storage-provider model of the API response ( this method here is given the included section as a parameter and uses it to find the icon_url https://github.com/CenterForOpenScience/angular-osf/blob/feature/pbs-25-24/src/app/shared/mappers/addon.mapper.ts#L60)
  • When connecting an addon via OAuth, this following method is called, and the response from the API does not contain the included section. This updates the existing authorized-storage-addon in the store as well. https://github.com/CenterForOpenScience/angular-osf/blob/develop/src/app/shared/services/addons/addons.service.ts#L93-L111
    • I tried adding a ?include=external-${addonType}-service to this PATCH request URL similar to other requests in this file, but it turns out that PATCH requests do not preserve the included section of a response anyways (https://github.com/CenterForOpenScience/angular-osf/blob/develop/src/app/shared/services/json-api.service.ts#L56). I could try to monkeypatch the included section into the returned data object if a PATCH request returns one (maybe something like data._included?), but I don't know if it's quite worth it at this juncture and may be a broader architectural decision to make with the team
  • Since the latest version of the authorized-storage-addon in the store (from getAuthorizedStorageOauthToken) does not have a icon_url, no icon is shown on the addon-card

Screenshot(s)

• See Pavlo's video in the JIRA ticket

Side Effects

QA Notes