[ENG-9046] shtrove cardsearch feeds #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace `trove.render._rendering` module with `trove.render.rendering` package (separate file for each rendering class) - make `ProtoRendering` an actual `typing.Protocol` and narrow types to only unicode `str` - add `trove.render.rendering.html_wrapped.HtmlWrappedRendering` that puts minimal `<!DOCTYPE html><pre>...</pre>` around an inner rendering - use `HtmlWrappedRendering` to wrap responses that aren't html or json, when `Accept` header allows html and query params omit `withFileName` - use mediatype constants more consistently (leaving off charset except for content-type header)
- stream pages as lists, not dicts with colliding keys - tidy types - move `iter_unique` to `trove.util.iter` and add tests
- add feed renderers:
- trove.render.cardsearch_rss
- trove.render.cardsearch_atom
- add feed paths:
- /trove/index-card-search/rss.xml
- /trove/index-card-search/atom.xml
- add links from cardsearch responses to feeds (with appropriate params)
- miscellaneous improvements:
- better renderer test coverage
- consolidate more shared logic into trove.util
- more accurate type annotations
and its field rendered_content to entire_content
- SimpleTrovesearchRenderer => TrovesearchCardOnlyRenderer - remove "simple" renderer convenience methods; it's not that hard to build an EntireRendering (previously named "SimpleRendering")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note: includes #885 because conflicts)