Fix Outpost Siege interaction and update Card lethal logic (Issue #4745) #9717
+340
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngesZone excludes Stack/Exile + Exiled). Initialize Localizer/Lang to prevent NPE during GameType init.
…tions to aid Outpost Siege simulations. Keep Issue4745Test disabled until full phase-driven harness is ready.
Contributor
|
Why are three different "issues" being lumped together in a single PR? |
Contributor
|
thanks for contributing |
tool4ever
reviewed
Feb 11, 2026
forge-game/src/test/java/forge/game/ability/ForgetOnMovedTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@tehdiplomat I apologize for lumping the changes. They were discovered while working on the Outpost Siege interaction and felt related enough to include together. I will make sure to separate unrelated changes in future PRs. @tool4ever Thanks for the recommendation on #9703, I will definitely check it out to better understand the static abilities. I have also pushed a fix for the hardcoded path you noticed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with Outpost Siege where the exiled card interaction was using 'ExileOnMoved' instead of 'ForgetOnMoved', causing incorrect behavior when the card left the battlefield. It also updates Card.java to correctly check for 'LethalDamageByPower' static abilities in the getLethal() method.