Remove redundant TriggerRemembered #9716
Merged
+51
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tool4ever
commented
Feb 10, 2026
tool4ever
commented
- this is mostly for Ratonhnhaké:ton, so that in case his tokens get doubled each reflexive trigger can only attach to the one from the associated instance.
- because triggers that remember something are always created fresh it seems rather pointless to copy them into SA
Hanmac
reviewed
Feb 11, 2026
Hanmac
approved these changes
Feb 11, 2026
Contributor
|
@tool4ever is this MR ready? |
Contributor
Author
|
probably, just a couple of things I'll check later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.