Skip to content

Various Tweaks - Adventure Event Ante and Keyboard Input#9712

Open
Jetz72 wants to merge 7 commits intoCard-Forge:masterfrom
Jetz72:fixes20260204
Open

Various Tweaks - Adventure Event Ante and Keyboard Input#9712
Jetz72 wants to merge 7 commits intoCard-Forge:masterfrom
Jetz72:fixes20260204

Conversation

@Jetz72
Copy link
Contributor

@Jetz72 Jetz72 commented Feb 10, 2026

  • Fixes an internal NPE that appeared here (though obviously the performance hang with large numbers of tokens isn't going anywhere any time soon).
  • Add support for Page Up/Down and the arrow keys to the mobile deck editor. Closes Add Page-up/down scroll functionality in inventory/deck. #9578.
  • As part of the above - Previously arrow keys would always be treated as a fling gesture in the LibGDX port. Now they're passed to a keyDown event if the fling event goes unhandled. It's possible there are side effects since this tweak applies across all UIs, but I didn't encounter any in my testing.
  • Ante results in adventure events now apply to the player's current event deck instead of their inventory.
  • Ante results in adventure matches with multiple games now apply results from all games instead of just the last one.

@Jetz72 Jetz72 requested a review from tehdiplomat February 10, 2026 15:44
@Jetz72 Jetz72 added GUI Adventure For the Adventure Module labels Feb 10, 2026
@Hanmac
Copy link
Contributor

Hanmac commented Feb 10, 2026

i picked the NPE fix

what also could have worked:
player.equals(event.result().getWinningLobbyPlayer());
because player should not be null?

@Jetz72
Copy link
Contributor Author

Jetz72 commented Feb 10, 2026

what also could have worked:
player.equals(event.result().getWinningLobbyPlayer());
because player should not be null?

Wasn't sure at the time if player would be null while spectating a game with only AI players. Decided using Objects.equals was easier than digging through the code to find out if it actually worked that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adventure For the Adventure Module GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Page-up/down scroll functionality in inventory/deck.

2 participants