Various Tweaks - Adventure Event Ante and Keyboard Input#9712
Open
Jetz72 wants to merge 7 commits intoCard-Forge:masterfrom
Open
Various Tweaks - Adventure Event Ante and Keyboard Input#9712Jetz72 wants to merge 7 commits intoCard-Forge:masterfrom
Jetz72 wants to merge 7 commits intoCard-Forge:masterfrom
Conversation
Contributor
Jetz72
commented
Feb 10, 2026
- Fixes an internal NPE that appeared here (though obviously the performance hang with large numbers of tokens isn't going anywhere any time soon).
- Add support for Page Up/Down and the arrow keys to the mobile deck editor. Closes Add Page-up/down scroll functionality in inventory/deck. #9578.
- As part of the above - Previously arrow keys would always be treated as a fling gesture in the LibGDX port. Now they're passed to a keyDown event if the fling event goes unhandled. It's possible there are side effects since this tweak applies across all UIs, but I didn't encounter any in my testing.
- Ante results in adventure events now apply to the player's current event deck instead of their inventory.
- Ante results in adventure matches with multiple games now apply results from all games instead of just the last one.
Contributor
|
i picked the NPE fix what also could have worked: |
Contributor
Author
Wasn't sure at the time if player would be null while spectating a game with only AI players. Decided using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.