Conversation
harryswift01
approved these changes
Apr 7, 2025
Member
harryswift01
left a comment
harryswift01
left a comment
There was a problem hiding this comment.
This looks like a nice way to ensure that the index issue is resolved to prevent out-of-bounds errors, I'm happy for this to be merged in.
jimboid
approved these changes
Apr 7, 2025
Member
jimboid
left a comment
jimboid
left a comment
There was a problem hiding this comment.
This looks to have contained the bug affecting the timesteps. Looks like an elegant solution with concise code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix an index issue that caused out of bounds errors when the start parameter for selecting a subset of frames from the trajectory was not zero.
Changes
In the get_matrices and assign_conformation functions where the code was looping over timesteps, changed from using timestep.frame to using an index that counts from the first timestep used rather than the frame number in the original trajectory (timestep_index = timestep.frame - start).
Impact