Removal of poseidon from CodeEntropy:#59
Merged
harryswift01 merged 1 commit intomainfrom Mar 12, 2025
Merged
Conversation
- Removed the everything in the CodeEntropy/poseidon/ directory - Removed the CodeEntropy/PoseidonHelper.py file - Resolved issue #52 of local variables being assigned and not used - Removal of poseidon got rid of most of the warnings - One variable that was assigned but not used within Example/create_new_universe.py has been commented out - Due to issue #52 being resolved the extend-ignore case for variables assigned but never used (F841) has been removed from the pyproject.toml file
This was
linked to
issues
Mar 11, 2025
Closed
jimboid
approved these changes
Mar 11, 2025
Member
jimboid
left a comment
There was a problem hiding this comment.
Looks like you got it all, nice you tightened up the linter in pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is apart of the major refactor of CodeEntropy, as the poseidon code is now being replaced with imports from waterEntropy which handles water entropy. The current poseidon code is no longer required hence its removal from CodeEntropy.
Changes
Poseidon Removal :
CodeEntropy/poseidon/directoryCodeEntropy/PoseidonHelper.pyfileUpdates to `pyproject.toml' File:
Example/create_new_universe.pyhas been commented outImpact