Conversation
harryswift01
approved these changes
Feb 12, 2026
Member
harryswift01
left a comment
There was a problem hiding this comment.
This looks like a very clean fix. Using MDAnalysis’ principal_axes() for the single-UA case should prevent the complex axis issue from the custom MOI-based implementation, and it looks like the relevant tests have been updated accordingly. I’m happy to approve this, thank you!
principal_axes() for single-UA molecules to prevent complex axes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Principal axes for molecules that were a single UA sometimes produced complex numbers when using the
custom_principal_axes()function as the translational axes for forces added to the covariance matrices.Changes
Change PA used for single UA molecules :
principal_axes()function instead of thecustom_principal_axes()Update tests :
make_wholepatch and remove redundant mocksImpact