Demo video-capture width and height must be divisible by 2#472
Open
sjoerdsmink wants to merge 3 commits intoBoboTiG:mainfrom
Open
Demo video-capture width and height must be divisible by 2#472sjoerdsmink wants to merge 3 commits intoBoboTiG:mainfrom
sjoerdsmink wants to merge 3 commits intoBoboTiG:mainfrom
Conversation
Width and height must be divisible by 2, otherwise the encoder will fail. Round down to the nearest even number.
Width and height must be divisible by 2, otherwise the encoder will fail. Round down to the nearest even number.
Owner
|
/cc @jholveck |
Contributor
|
I would suggest changing the capture resolution too; not sure what the libraries will do if they don't match, but making them match is probably best. In the non-simple demo, I would also conditionalize this on the codec being libx264: not all codecs have this limitation (I just tested on h264_nvenc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the resolution is not an even number, it generates an error:
Changes proposed in this PR
Fixes #
Width and height must be divisible by 2, otherwise the encoder will fail. Round down to the nearest even number.
./check.shpassed