Basic CLI #21
Draft
Basic CLI #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyrylR
force-pushed
the
feature/basic-cli
branch
from
db76675 to
98cce75
Compare
KyrylR
commented
Dec 29, 2025
crates/coin-store/src/store.rs
Outdated
| use crate::filter::Filter; | ||
|
|
||
| static MIGRATOR: Migrator = sqlx::migrate!(); | ||
| const BLINDING_KEY_LEN: usize = 32; |
Collaborator
Author
There was a problem hiding this comment.
Let's have a single constant, look whether elements already have it (related to the SEED_LEN)
crates/cli-client/src/cli/basic.rs
Outdated
|
|
||
| let results: Vec<UtxoQueryResult> = wallet.store().query(&[filter]).await?; | ||
|
|
||
| // todo: add merging |
Collaborator
Author
There was a problem hiding this comment.
Please use TODO(whoisgoingtodothat): ....
crates/cli-client/src/cli/basic.rs
Outdated
| .sign_p2pk(&tx, utxos, 0, config.address_params(), *LIQUID_TESTNET_GENESIS)?; | ||
| let native_utxo = (*native_entry.outpoint(), native_entry.txout().clone()); | ||
|
|
||
| // todo: maybe even in transfer native extract fee from input utxo (use as separate one) |
Collaborator
Author
There was a problem hiding this comment.
Do not understand this todo
Comment on lines
79
to
83
| Utxos { | ||
| /// Sets script for filtering in wallet | ||
| #[arg(long, long = "mine", default_value_t = false)] | ||
| is_mine: bool, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
Let's not add it yet
Collaborator
Author
There was a problem hiding this comment.
I envision a different implementation for that
crates/cli-client/src/cli/common.rs
Outdated
| } | ||
|
|
||
| impl Broadcaster { | ||
| /// Broadcasts created transaction or returns raw transaction as hex string |
Collaborator
Author
There was a problem hiding this comment.
Delete this commit pls (let's not have comments that state the same thing as function name)
crates/cli-client/src/cli/common.rs
Outdated
|
|
||
| impl Broadcaster { | ||
| /// Broadcasts created transaction or returns raw transaction as hex string | ||
| pub async fn broadcast_tx(&self, wallet: &Wallet, tx: &Transaction, outpoints: &[OutPoint]) -> Result<(), Error> { |
Collaborator
Author
There was a problem hiding this comment.
Why do we need outpoints if we have tx
Comment on lines
28
to
39
| CREATE TABLE option_params | ||
| ( | ||
| script_pubkey BLOB NOT NULL PRIMARY KEY, | ||
| start_time BLOB NOT NULL, | ||
| expiry_time BLOB NOT NULL, | ||
| collateral_per_contract BLOB NOT NULL, | ||
| settlement_per_contract BLOB NOT NULL, | ||
| collateral_asset_id BLOB NOT NULL, | ||
| settlement_asset_id BLOB NOT NULL, | ||
| option_token_entropy BLOB NOT NULL, | ||
| grantor_token_entropy BLOB NOT NULL | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
This is bad design.....
Collaborator
Author
There was a problem hiding this comment.
Let's discuss it offline, though in a nutshell this module should not be responsible for that
Comment on lines
17
to
40
| async fn insert(&self, name: &str, asset_id: AssetId) -> Result<(), StoreError> { | ||
| let asset_entropy = asset_id.into_inner().0; | ||
|
|
||
| let existing: Option<(i64,)> = sqlx::query_as("SELECT 1 FROM assets WHERE asset_name = ?") | ||
| .bind(name) | ||
| .fetch_optional(&self.pool) | ||
| .await?; | ||
|
|
||
| if existing.is_some() { | ||
| return Err(StoreError::AssetIdAlreadyExists(name.to_string())); | ||
| } | ||
|
|
||
| let mut tx = self.pool.begin().await?; | ||
|
|
||
| sqlx::query("INSERT INTO assets (asset_name, asset_id) VALUES (?, ?)") | ||
| .bind(name) | ||
| .bind(asset_entropy.as_slice()) | ||
| .execute(&mut *tx) | ||
| .await?; | ||
|
|
||
| tx.commit().await?; | ||
|
|
||
| Ok(()) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is not according to how I see this thing
ikripaka
force-pushed
the
feature/basic-cli
branch
from
74013d5 to
2be661f
Compare
KyrylR
force-pushed
the
feature/basic-cli
branch
from
2be661f to
63d87b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.