feat(wasm): add Rust BIP32 implementation #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WebAssembly BIP32 implementation with ECPair functionality for: - Hierarchical Deterministic key derivation (BIP32) - Compressed public key management - Bitcoin message signing and verification (BIP137) - ECDSA signing and verification The implementation provides a minimal, secure foundation for wallet operations. Issue: BTC-2915 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2915.add-wasm-bip32
branch
from
93b977c to
7fa4b96
Compare
- Split single job into parallel test jobs for each package - Build job runs first, uploads artifacts - test-wasm-bip32 and test-wasm-utxo run in parallel after build - test-integration runs after both test jobs complete
- Add environment variables for tool versions - Consolidate test jobs using matrix strategy - Use conditional steps for package-specific behavior - Reduces workflow from 241 to ~170 lines
- Add #[allow(dead_code)] for internal methods reserved for future use - Remove unnecessary borrows in Ripemd160::digest calls
The critical-section feature was causing an 'env' import in the wasm module which is not supported by the Node.js wasm loader.
…bility The precomputed-tables feature requires critical-section which adds env imports to the wasm module that Node.js cannot resolve. ECDSA operations still work without precomputed tables, just slightly slower.
- Add k256 precomputed-tables feature for faster elliptic curve operations - Provide custom critical-section implementation for WASM (single-threaded no-op) - Restore benchmark test to 1000 iterations Performance improvements: - derivePath from xpub: ~2x faster than utxo-lib - derive single child: ~2.2x faster than utxo-lib - fromBase58 (xpub): ~3x faster than utxo-lib
Simpler approach - no custom code needed. Slightly larger WASM (+4K) but cleaner codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WebAssembly BIP32 implementation with ECPair functionality for:
The implementation provides a minimal, secure foundation for wallet
operations.
BTC-2915