feat: read ZecConsensusBranchId from PSBT unknown map #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
previously approved these changes
Jan 8, 2026
When utxo-lib serializes a Zcash PSBT, the ZecConsensusBranchId proprietary key ends up in the raw `unknown` map rather than the parsed `proprietary` map when deserialized by rust-bitcoin. This caused KeyNotFound errors during signing when using wasm-utxo with PSBTs created by utxo-lib. Modified get_zec_consensus_branch_id() to check both maps: 1. First check the `proprietary` map (where wasm-utxo stores it) 2. Fall back to the `unknown` map (where utxo-lib stores it) The unknown map lookup uses rust-bitcoin's raw::Key struct fields: - type_value: 0xfc (proprietary key type) - key: [0x05, 'B', 'I', 'T', 'G', 'O', 0x00] (varint len + identifier + subtype) This is a temporary workaround while BitGoJS uses a mix of utxo-lib and wasm-utxo for Zcash PSBT operations. Ticket: BTC-2917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When utxo-lib serializes a Zcash PSBT, the ZecConsensusBranchId proprietary
key ends up in the raw
unknownmap rather than the parsedproprietarymap when deserialized by rust-bitcoin. This caused KeyNotFound errors
during signing when using wasm-utxo with PSBTs created by utxo-lib.
Modified get_zec_consensus_branch_id() to check both maps:
proprietarymap (where wasm-utxo stores it)unknownmap (where utxo-lib stores it)The unknown map lookup uses rust-bitcoin's raw::Key struct fields:
This is a temporary workaround while BitGoJS uses a mix of utxo-lib and
wasm-utxo for Zcash PSBT operations.
Ticket: BTC-2917