feat(sdk-core): add automatic signature cleanup for Express TSS signing#7256
Merged
feat(sdk-core): add automatic signature cleanup for Express TSS signing#7256
Conversation
nvjsr
previously approved these changes
Oct 16, 2025
Contributor
|
@claude review |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an API gap in the Express TSS signing endpoint where re-signing partially signed Full TxRequests would fail due to stale signature shares. The solution adds automatic signature cleanup before signing operations.
- Adds signature share cleanup logic to detect and clean partial signatures before signing
- Updates Express TSS signing endpoint to use the new cleanup method
- Provides comprehensive test coverage for the signature cleanup scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/sdk-core/src/bitgo/wallet/wallet.ts | Adds ensureCleanSigSharesAndSignTransaction method with signature cleanup logic |
| modules/express/src/clientRoutes.ts | Updates Express TSS signing to use new cleanup method |
| modules/bitgo/test/v2/unit/wallet.ts | Adds comprehensive unit tests for signature cleanup functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kamleshmugdiya
previously approved these changes
Oct 16, 2025
sachinBitgo
reviewed
Oct 16, 2025
b8a43f0 to
ae9c08f
Compare
ae9c08f to
f8fcd9e
Compare
f8fcd9e to
71b889c
Compare
b17eb7d to
c222e83
Compare
Fixes Express API gap where re-signing partially signed Full TxRequests would fail. The /signtxtss route now always cleans up signature shares for txRequest full before attempting to sign. Changes: - Add ensureCleanSigSharesAndSignTransaction() to Wallet class - Update Express handleV2SignTSSWalletTx() to use new method - Add comprehensive unit tests for signature cleanup logic Ticket: COIN-5989
c222e83 to
1a8eff8
Compare
kaustubhbitgo
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Express API gap where re-signing partially signed Full TxRequests would fail. The /signtxtss route now automatically detects and cleans up partial signature shares before attempting to sign.
Changes:
Benefits:
Ticket: COIN-5989