feat(express): migrate handleCreateSignerMacaroon to typed routes#6967
Closed
danielzhao122 wants to merge 14 commits intomasterfrom
Closed
feat(express): migrate handleCreateSignerMacaroon to typed routes#6967danielzhao122 wants to merge 14 commits intomasterfrom
danielzhao122 wants to merge 14 commits intomasterfrom
Conversation
Taseen08
previously approved these changes
Sep 11, 2025
modules/express/test/unit/clientRoutes/lightning/lightningSignerRoutes.ts
Outdated
Show resolved
Hide resolved
OttoAllmendinger
requested changes
Sep 16, 2025
modules/express/test/unit/clientRoutes/lightning/lightningSignerRoutes.ts
Outdated
Show resolved
Hide resolved
zahin-mohammad
previously approved these changes
Sep 19, 2025
modules/express/test/unit/clientRoutes/lightning/lightningSignerRoutes.ts
Outdated
Show resolved
Hide resolved
zahin-mohammad
approved these changes
Sep 19, 2025
alextse-bg
previously approved these changes
Sep 19, 2025
mohammadalfaiyazbitgo
previously approved these changes
Sep 22, 2025
OttoAllmendinger
previously approved these changes
Sep 22, 2025
zahin-mohammad
previously approved these changes
Sep 25, 2025
danielzhao122
dismissed stale reviews from zahin-mohammad, OttoAllmendinger, mohammadalfaiyazbitgo, and alextse-bg
via
5f9a6b1
danielzhao122
requested review from
OttoAllmendinger,
Taseen08,
mohammadalfaiyazbitgo and
zahin-mohammad
zahin-mohammad
requested changes
Sep 29, 2025
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
Changes to express.lightning.signerMacaroon seem fine, but looks like a bad merge conflict resolution.
Taseen08
reviewed
Oct 9, 2025
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
lgtm, but conflicts
danielzhao122
force-pushed
the
WP-5445-express-migrate-api-v2-coin-wallet-id-signer-macaroon-to-typed-routes
branch
from
329cb8d to
ee326a2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Taseen08
reviewed
Oct 17, 2025
Contributor
Taseen08
left a comment
Taseen08
left a comment
There was a problem hiding this comment.
CI failures + copilot suggestion (not sure if that's relevant)
modules/express/test/unit/clientRoutes/lightning/lightningSignerRoutes.ts
Outdated
Show resolved
Hide resolved
zahin-mohammad
previously approved these changes
Oct 22, 2025
mohammadalfaiyazbitgo
previously approved these changes
Oct 30, 2025
alextse-bg
previously approved these changes
Nov 4, 2025
danielzhao122
dismissed stale reviews from alextse-bg, mohammadalfaiyazbitgo, and zahin-mohammad
via
e08294c
lcovar
previously approved these changes
Nov 5, 2025
TICKET: WP-5445
lcovar
approved these changes
Nov 12, 2025
davidkaplanbitgo
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5445