Ap 547: Add other healthchecks to Geodata #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarchivist
requested changes
Jan 15, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
I think this is a good start but I'd like to see this check be closer in alignment to how OkComputer::Check defines its API. I have some questions about whether some of the classes and methods are necessary. Let me know if you'd like to discuss this further!
anarchivist
reviewed
Jan 16, 2026
Contributor
Author
|
@anarchivist I did the updates accordingly, could you please take a look? Thanks |
anarchivist
reviewed
Jan 20, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
Looks good - I think the one other thing I would add are RSpec tests for EndpointUrl and GeoDataHealthCheck::HttpHeadCheck. Then I think this is ready to go!
anarchivist
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add http head check to geoservers and spatial servers