Skip to content

models: Prepend empty item to Alma Item Set lists #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awilfox wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

models: Prepend empty item to Alma Item Set lists #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/alma/item_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def prepend_note_to_set(env, id, note, num, email)
def fetch_item_sets(source)
# We can only fetch 100 item sets at a time so we
# have to loop through the API to get all of them
sets = []
sets = [['', '']]
Copy link
Member

@anarchivist anarchivist Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we move this line to just under the method and add a comment about why it's initializing an Array containing an Array with 2 empty strings as its elements?

offset = 0

loop do
Expand Down