Closed
Conversation
In Fortran preprocessor, the usage:
#ifdef A && B
is treated as `#ifdef A` and the `&& B` is ignored as "extra tokens",
which is most likely not what was intended. Most likely what was
intended is:
#if defined(A) && defined(B)
So this PR makes this change.
certik
commented
Feb 25, 2026
| allocate(DA, mold=A) | ||
|
|
||
| #ifdef HAVE_DO_CONCURRENT_TYPE_SPEC_SUPPORT && HAVE_LOCALITY_SPECIFIER_SUPPORT | ||
| #if defined(HAVE_DO_CONCURRENT_TYPE_SPEC_SUPPORT) && defined(HAVE_LOCALITY_SPECIFIER_SUPPORT) |
Contributor
Author
There was a problem hiding this comment.
Actually what was likely intended is:
Suggested change
| #if defined(HAVE_DO_CONCURRENT_TYPE_SPEC_SUPPORT) && defined(HAVE_LOCALITY_SPECIFIER_SUPPORT) | |
| #if HAVE_DO_CONCURRENT_TYPE_SPEC_SUPPORT && HAVE_LOCALITY_SPECIFIER_SUPPORT |
@rouson can you clarify?
Contributor
Author
There was a problem hiding this comment.
I am pretty sure this is the correct fix: #11.
Contributor
Author
|
Closing in favor of #11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Fortran preprocessor, the usage:
is treated as
#ifdef Aand the&& Bis ignored as "extra tokens", which is most likely not what was intended. Most likely what was intended is:So this PR makes this change.