Conversation
lphoumpakka
requested review from
Rahe,
asadowski10,
firestar300,
petitphp and
ptesei
petitphp
reviewed
Jan 9, 2023
Member
petitphp
left a comment
petitphp
left a comment
There was a problem hiding this comment.
On parse déjà le assets.json dans le service Assets. Pour moi, ce serait plus intéressant de déplacer ces modifications à cet endroit.
petitphp
reviewed
Jan 23, 2023
Member
petitphp
left a comment
petitphp
left a comment
There was a problem hiding this comment.
Merci pour la modification.
Il faudrait faire une autre modification pour travailler directement avec l'instance du container pour récupérer le service Assets et l'utiliser dans les méthodes.
Rahe
requested changes
Mar 6, 2023
petitphp
requested changes
Jun 4, 2024
| $file = $assets['app.js'] ?? ''; | ||
| break; | ||
| default: | ||
| $file = null; |
Member
There was a problem hiding this comment.
Plutôt que d'avoir le code pour le custom type après, je l'aurais déplacé ici :
Suggested change
| $file = null; | |
| $file = $assets[ $type ] ?? ''; |
Et supprimer la partie après :
// Custom type
if ( ! empty( $assets[ $type ] ) ) {
$file = $assets[ $type ];
}
Contributor
|
@lphoumpakka c'est toujours d'actu cette PR de 2023 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.