Reflection notification time setting

[kodjima33]

Add user-configurable time setting for daily reflection notifications in the Omi mobile app.

Previously, daily reflection notifications were hardcoded to 9 PM local time. This PR introduces a new setting in the app's notification settings page, allowing users to select their preferred hour for these notifications. The chosen time is persisted in the backend, ensuring cross-device sync and persistence across app restarts, and updates the local notification scheduling logic.

---

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[gemini-code-assist]

Code Review

This pull request introduces a user-configurable time setting for daily reflection notifications, which is a great enhancement for user experience. The changes are well-implemented across both the backend and the mobile app, with good attention to consistency and backward compatibility. The new API endpoints are robust, and the UI changes are intuitive. I've found one high-severity issue related to the fallback behavior on app launch, which could prevent notifications from being scheduled under certain network conditions. Addressing this will make the feature more resilient.

[gemini-code-assist]

The current implementation of _scheduleDailyReflectionIfEnabled does not handle the case where getDailyReflectionSettings() returns null (e.g., due to a network error). This will cause the daily reflection notification to not be scheduled on app launch if the API call fails, which contradicts the intended fallback behavior mentioned in the pull request description ("If API call fails, system falls back to local default (9 PM)").

To ensure notifications are scheduled reliably even with intermittent network issues, you should provide default values for enabled and hour when the API call fails.

Future<void> _scheduleDailyReflectionIfEnabled() async {
  final settings = await getDailyReflectionSettings();
  // Fallback to default values if API call fails
  final enabled = settings?.enabled ?? true;
  final hour = settings?.hour ?? 21;

  if (enabled) {
    DailyReflectionNotification.scheduleDailyNotification(
      channelKey: 'channel',
      hour: hour,
    );
  }
}

[beastoin]

Closing this stale draft — no activity in 3+ days. Feel free to reopen when it's ready for review.

[github-actions]

Hey @kodjima33 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

• Project standards — Ensuring consistency across the codebase
• User needs — Making sure changes align with what our users need
• Code best practices — Maintaining code quality and maintainability
• Project direction — Keeping aligned with our roadmap and vision

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community! 💜