portfolio-trading-accounts upsert#584
Open
apawan wants to merge 1 commit intoinvestment-service/phase-2-data-models-ingestionfrom
Open
portfolio-trading-accounts upsert#584apawan wants to merge 1 commit intoinvestment-service/phase-2-data-models-ingestionfrom
apawan wants to merge 1 commit intoinvestment-service/phase-2-data-models-ingestionfrom
Conversation
|
Aboruhen
reviewed
Feb 20, 2026
| return Mono.just(existingAccount); | ||
| } | ||
|
|
||
| private void logPortfolioTradingAccountPatchError(String uuid, Throwable throwable) { |
Collaborator
There was a problem hiding this comment.
Loging methods can be merged into one common
| private List<PortfolioProduct> portfolioProducts; | ||
| private InvestmentAssetData investmentAssetData; | ||
| private List<PortfolioList> portfolios; | ||
| private List<InvestmentPortfolioAccount> investmentPortfolioAccounts; |
Collaborator
There was a problem hiding this comment.
Do not overcomplicate the implementation.
The model is split into 2 separate properties and iterated over itself; it doesn't improve logic.
For trading accounts, you just have a simple model for insert/update, just do it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Checklist