{Core} Revert #32518 using threads to build command table for performance #32695
+47
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zure#32518)" This reverts commit 6a70dae.
DanielMicrosoft
requested review from
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @DanielMicrosoft, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts commit 6a70dae (PR #32518), which had introduced threading to the command table building process for performance improvements. The revert removes the concurrent module loading implementation and restores sequential, synchronous loading of command modules and extensions.
Changes:
- Removed threading-based parallel module loading infrastructure and restored sequential loading
- Removed
ModuleLoadResultclass and associated helper methods for parallel processing - Deleted the
test_command_table_integrity.pytest file that was specific to threading implementation - Updated test assertions to check for deterministic ordering instead of unordered sets
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli-core/azure/cli/core/__init__.py |
Removed threading imports, constants, and methods; restored sequential module loading in _update_command_table_from_modules |
src/azure-cli-core/azure/cli/core/commands/__init__.py |
Modified _load_command_loader to populate cmd_to_loader_map and changed return signature |
src/azure-cli-core/azure/cli/core/tests/test_parser.py |
Updated mock function return signature to match reverted implementation |
src/azure-cli-core/azure/cli/core/tests/test_command_registration.py |
Updated mock function and changed assertions from unordered set to ordered list comparison |
src/azure-cli-core/azure/cli/core/tests/test_command_table_integrity.py |
Deleted entire file as it was specific to threading implementation testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DanielMicrosoft
changed the title
DanielMicrosoft
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
DanielMicrosoft
modified the milestones:
March 2026 (2026-03-03),
February 2026 (2026-02-03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6a70dae, after this issue was found: #32518 (comment)
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.