fix SaveLoad for an obscure edge case #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a ship that hasn't arrived yet, and that ship has a turret with a changed weapon on it, then restoring a checkpoint will cause a crash. This is because subsystems on parse objects use the weapon class directly, not weaponbanktype. This PR fixes the crash.
Goober5000
added a commit
to Goober5000/fso-scripts
that referenced
this pull request
Aug 19, 2022
…t with a changed weapon on it, then restoring a checkpoint will cause a crash. This is because subsystems on parse objects use the weapon class directly, not weaponbanktype. This PR fixes the crash. This corresponds to the old PR 6: AxemP/AxemFS2Scripts#6
Goober5000
added a commit
to Goober5000/fso-scripts
that referenced
this pull request
Aug 19, 2022
If you have a ship that hasn't arrived yet, and that ship has a turret with a changed weapon on it, then restoring a checkpoint will cause a crash. This is because subsystems on parse objects use the weapon class directly, not weaponbanktype. This PR fixes the crash. This corresponds to the old PR 6: AxemP/AxemFS2Scripts#6
BMagnu
pushed a commit
to FSO-Scripters/fso-scripts
that referenced
this pull request
Aug 19, 2022
If you have a ship that hasn't arrived yet, and that ship has a turret with a changed weapon on it, then restoring a checkpoint will cause a crash. This is because subsystems on parse objects use the weapon class directly, not weaponbanktype. This PR fixes the crash. This corresponds to the old PR 6: AxemP/AxemFS2Scripts#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a ship that hasn't arrived yet, and that ship has a turret with a changed weapon on it, then restoring a checkpoint will cause a crash. This is because subsystems on parse objects use the weapon class directly, not weaponbanktype. This PR fixes the crash.