You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's sample file for wp-cache-config.php. Function wp_cache_replace_line parses line by line and it isn't possible to use few lines (eg. Array( ...).
So, I think that's better to we ignore this file now. Maybe we can improve it in the future, but it could make side effects with current code.
I'm not sure because wp_cache_setting will override these changes. I'm just looking and I think that we need to improve wp_cache_setting, wp_cache_replace_line, wp_cache_update_rejected_pages and probably something more.
I'd like to improve regular expression https://github.com/Automattic/wp-super-cache/blob/master/wp-cache-phase2.php#L1086 before we continue with this file.
I just created first version - PR #487. It works by my quick testing. Please review it and test it. I see more places which should be improved, current code isn't perfect, but good for start. I'll continue tomorrow if I find free time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPCS fixes via PHPCS.