Skip to content

Conversation

@Shironex
Copy link
Collaborator

  • Modify the condition for using structured output to include both Claude and Codex models, ensuring compatibility with the latest model capabilities.

- Modify the condition for using structured output to include both Claude and Codex models, ensuring compatibility with the latest model capabilities.
@Shironex Shironex self-assigned this Jan 23, 2026
@Shironex Shironex added the Bug Something isn't working label Jan 23, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Shironex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logic for generating structured output in API specifications by updating the conditions under which this feature is enabled. The change ensures that the application correctly identifies and utilizes the structured output capabilities of Claude and Codex models, leading to more accurate and reliable spec generation.

Highlights

  • Model Type Checking Update: Replaced the isCursorModel check with isClaudeModel and isCodexModel to accurately identify models capable of structured output.
  • Structured Output Logic Refinement: Modified the useStructuredOutput condition to explicitly enable structured output only for Claude and Codex models, ensuring compatibility with their specific capabilities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

A condition for enabling structured output was modified to explicitly target Claude and Codex models instead of excluding only Cursor models, narrowing the set of models that support this feature.

Changes

Cohort / File(s) Summary
Structured Output Model Logic
apps/server/src/routes/app-spec/generate-spec.ts
Modified condition from !isCursorModel(model) to isClaudeModel(model) || isCodexModel(model) for enabling structured output, changing from an exclusionary approach to an explicit inclusion list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through logic gates so clear,
From "not this" to "yes, these, my dear!"
Claude and Codex get the structured way,
A tighter grip—hooray, hooray! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating structured output logic to apply to Claude and Codex models instead of excluding Cursor models.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refines the logic for using structured output in spec generation. The change correctly limits structured output to Claude and Codex models, which is a more explicit and safer approach than the previous implementation. The code is clear, and the change directly addresses the intended fix. Overall, this is a good improvement for model compatibility and robustness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants